picotool icon indicating copy to clipboard operation
picotool copied to clipboard

Preserving of P8SCII Control Codes

Open Liquidream opened this issue 3 years ago • 3 comments

(I believe you've yet to look at P8SCII, so this is just an FYI for when you do)

Currently, when picotool/luamin processes source files wish such code as below:

print("\^w\^thello world")

...it results in the backslashes being escaped (breaking the P8SCII Control Codes):

print("\\^w\\^thello world")

Liquidream avatar Sep 19 '21 15:09 Liquidream

Just ran into this one again while updating SCUMM-8. I guess this more a case of preserving single backslashes "" Which I guess might be a challenge for your parser? (hope not)

Liquidream avatar Apr 22 '22 05:04 Liquidream

I also needed to write instructions such as "Press 🅾 (O glyph)" and the 🅾 (O glyph) became "ユか✽ゆヤま◆". After processing Lua content with Python, it was even flattened to "_______" (this is an issue on my side, not sure why as I'm processing UTF-8; but first the issue must be fixed on picotool side, then I can see if I need more work to make the glyph work).

I saw some update of glyphs and updated picotool to latest, but the issue was still there.

hsandt avatar May 19 '22 15:05 hsandt

I recently encountered the same issue as @hsandt and decided to look into it. I was able to remove the issue by disabling all unescaping of P8SCII escape sequences. I believe this should solve your issue as well, @Liquidream.

I made a PR for the suggested fix.

simonwulf avatar Aug 10 '22 00:08 simonwulf