Daniel Rotter

Results 200 comments of Daniel Rotter

@glours I just checked your PR, and it looks to me like it only solves one part of this issue. The PR seems to only allow adding new lines although...

I was just running into the same use case 😅 Why only allow this for single use variables? Also in my case it is a class constant I'd like to...

Martin Fowler also describes the "Inline variable" refactoring in his book "Refactoring Patterns". It can definitely be useful, in our particular situation the class constant is used in string concatenation,...

What I forgot to mention: I also stumbled upon this issue from another repository, which sounds very familiar: https://github.com/yegappan/lsp/issues/130#issuecomment-1472232696 Is it possible that this `textEdit` feature, in particular the range...

@mattriverm Haven't found that so far. I tried it and it works. So I guess I am good for now, but this is not the final solution, right? Or is...

The exact same thing is also happening with PHP annotations, and I don't see a phpactor option to disable that: https://asciinema.org/a/MNYAFcYC19AHnIYJvSY8B7vrl

I've been working with this workaround for quite some time now, and while it works in some situations, it feels like it makes problems in others. I.e. sometimes I am...

@webdev23 I don't think that this issue can be closed, I am working with that workaround for half a year now, and it is really just a workaround. As mentioned...

@mattriverm Cool! Any chance you could create a PR for that? I guess I'll also mention @dantleech to see what he thinks about this 🙂

I just tested it, and I think it is not removed, but the number is interpreted as ID, and tries to load the tag with that ID... Also still happens...