Dan Rivett

Results 35 comments of Dan Rivett

I just ran into this, and can confirm paradoxically removing the `!` from the connected model (`TestModel` in the example above) avoids the error as well for me. The downside...

Isn't the bug here?: https://github.com/aws-amplify/amplify-cli/blob/master/packages/amplify-codegen-appsync-model-plugin/src/utils/process-connections.ts#L201 There are only 3 branches in the `if` statement checking if both sides of the connection are null or not: - `if (!field.isNullable && otherSideField.isNullable)`...

@kldeb we removed the connection for now instead of money-patching; we monkey-patched just to prove out the theory that the if-block is missing a clause and it would fall into...

Curious @stocaaro if this PR has been replaced with a different PR to address this issue? I haven't read through the PR commits, but from the description it's definitely something...

Thanks @alharris-at that makes sense now, thanks for letting me know. We were just following this PR in particular, so got notified when it got closed.

Thanks for the reviews @johnhooks and @sarahdayan. I will implement these actions in the next week, I'm just in the middle of a story so want to get that wrapped...

The PR (#646) is built on top of the `main` branch, but in the meantime I've also built patch files on top of the latest released version as of this...

As a follow-up I just published a new commitlint plugin - [commitlint-plugin-github](https://github.com/elevai-consulting/commitlint-github) - which was the trigger for this feature request. Currently I've had to revert code in the plugin...

I'd also love to see v3 released as ran into #54 and I would rather not depend in production on an rc build that's been released 10 months ago as...

> I was able to get rid of `aws-sdk` package which is nested dependency (production dependency for some of my dependencies) with: > > ```yaml > custom: > webpack: >...