Daniel Povey
Daniel Povey
It would be fine to just replace FLT_MAX in the code with that constant, and put // FLT_MAX as a comment.
@jimbozhang perhaps you'd like to comment? If you don't object, I'm inclined to just merge this when it's marked done (i.e. draft label removed)
Yeah the new maintainers of openfst don't have a lot of respect for back compatibility it seems. I think the right fix would be something where beforehand we figure out...
Looks like you need to add back the "remove python2 installation" thing.. i thought I saw that in there beore.
It should dump the offending batch if your script is fairly up to date. You could load the .pt file with torch.load(), and see the characteristics of the batch. E.g....
Which directory did you get the code? The later version in zipformer/ is more stable, there are earlier versions that eventually get unstable like that. If you run from the...
well if it's a git repo "git log -1" might tell you, if you are using a pip package then pip show icefall. but what directory did you find the...
Perhaps you are limited by the latency of individual operations, e.g. loading the kernels? The nsys profile output may give more detailed info. Unfortunately it won't look that pretty or...
I had my wife check that it compiles for her and it was OK. I want to keep this moving or people will become dispirited from the slow progress, so...
Wait, I see there's a test failing, let me see if I can fix it. Edit: can't reproduce right now as we're having problems connecting to the outside from our...