Daniil Gentili

icon indicating a website link https://blog.daniil.it icon indicating an email [email protected]

icon location Italy icon location Senior software artisan using Rust, Golang, C++, C, PHP. Maintainer of Psalm.

Results 256 comments of Daniil Gentili

Fix foreach after the garbage collector is invoked

Fixed up everything!

Fix foreach after the garbage collector is invoked

The codebase was successfully formatted using `scripts/clang-format.sh` locally with clang-format 20, not sure why is it complaining here; can't access the evergreen tests so I can't see what's wrong there

Fix foreach after the garbage collector is invoked

I simply compiled both php and the extension with ASAN/LSAN, which is even better than PHP's builtin leak detection, but the issue is that there are many unfixed leaks in...

5.4: Issue with flow analysis causes NoValue false positive

Encountered this too when making a PR, possibly caused by https://github.com/vimeo/psalm/pull/8934 The issue is that the if statement is analyzed twice, once with the impossible values inferred on the first...

5.4: Issue with flow analysis causes NoValue false positive

Yeah, in the case of https://psalm.dev/r/b33c14eaf6 there should be a paradox since `$v` is always > 0, there's already an open issue for this: https://github.com/vimeo/psalm/issues/8059. Overall I think the current...

5.4: Issue with flow analysis causes NoValue false positive

cc @orklah just in case you want to comment on this too