Daniel O’Connor

Results 66 comments of Daniel O’Connor

@hsiaoman87 shared this approach: https://material-ui.com/demos/buttons/ We should look at a few other UI libraries and compare the approaches.

Something similar to this approach? https://nextjs.org/docs#with-link https://github.com/zeit/next.js/blob/master/examples/hello-world/pages/index.js#L3

Thanks for making this! My initial guess is that it's related to this line: https://github.com/thumbtack/thumbprint/blob/be39ce04f9ca6bd3a2d908923cec3d3485a3d926/packages/thumbprint-react/components/Carousel/index.tsx#L59

Thoughts on the approaches. 1. Easiest to implement, but results in duplicate work for the consumer. This makes it easier for consumers to accidentally introduce bugs or visual inconsistencies. 2....

Hey @georgeashworth — What are your thoughts on these three approaches?

Another simpler option is to make the text gray if `value` is `""`.

@tomgenoni, @volanStudio — What do you think here? I'm torn on either closing this as a won't fix or exploring the most recent option I posted.

Hi @xanderwebs! If I remember correctly, this was intentional because Joe J., at the time, didn't want to support side-by-side full width buttons. We typically use right-aligned buttons within modals...

Hi @xanderwebs! @jonpkerwin and I have been working on buttons lately and it looks like we'll be making this 50/50 button layout an official pattern. I'll keep this open until...