entity-controller icon indicating copy to clipboard operation
entity-controller copied to clipboard

Published 20 hours ago • verified publisher icon danobot

feat: warn about mismatched timezones #311

Open Tabisch opened this issue 2 years ago • 4 comments
trafficstars

Description

With this pull request i want to introduce a error message, if the home assistant and system timezones are mismatched. This may cause the start_time_callback function to get called repeatedly.

With this change the user should become aware, that their current configuration might be an issue.

Checklist

  • [x ] The PR title is clear, concise and follows conventional commit formatting.
  • [x ] Double-check your branch is based on develop and targets develop
  • [x ] Issue raised to compliment this PR (if no pre-existing issue exists)
  • [ ] Code is commented, particularly in hard-to-understand areas and relevant issues are referenced.
  • [ ] Documentation repository updated to reflect new features or changes in behaviour (VERY IMPORTANT, undocumented features cannot be discovered and used!)
  • [x ] Description explains the issue/use-case resolved and auto-closes related issues.
  • [ ] Breaking changes or changes in behaviour are called out and discussed in separate issues.
  • [x ] Testing of new changes completed by person who raised the issue.

Please open an issue before embarking on any significant pull request, especially those that add a new library or change existing tests, otherwise you risk spending a lot of time working on something that might not end up being merged into the project.

License

By submitting a patch, you agree to allow the project owners to license your work under the terms of the project license. Thank you for contributing!

Related Issues

#311

Closes

Tabisch avatar Nov 09 '23 14:11 Tabisch

Hi @Tabisch , this looks good. Please remove any version bumps and edits to md or json files (they are automatic). Once done I will merge

danobot avatar Jan 13 '24 05:01 danobot

Hi @Tabisch , if you can remove the changes requested above I'm happy to merge this to develop and test

danobot avatar Feb 14 '24 12:02 danobot

@danobot Really sorry that I didn’t awnser you. Have been busy with Uni and am currently on a trip. I will do that next week. I’m back home on the 20th so I will try to get that done til the sunday after that.

Tabisch avatar Feb 14 '24 13:02 Tabisch

Did a rebase to develop. I hope this gets rid of the bumps and edits that you mentioned. The compare thing tells me that only the init.py is now changed compared to that branch.

Sorry im not that familiar with git so I dont know if that's how this works.

Tabisch avatar Feb 20 '24 18:02 Tabisch