Daniel Xu
Daniel Xu
``` The map above is now printed: @my_map[(1, hi)]: 1 Instead of: @my_map[1, hi]: 1 ``` Why change this? Semantically they are identical but adding `()` adds more visual noise....
Yeah I think if we did this clean slate I would've leaned towards keeping the parenthesis in just for implementation simplicity. But I would also said it's b/c I'm lazy...
I will take another look this week
High level makes sense to me. How do we plan on thinking about probe args (colon separated) vs probe attributes? When do we pick one over the other when adding...
> I'd say that colon separated probe arguments should be used for required arguments and named attributes for optional things. sgtm. Your analysis of existing rule breakers also make sense...
Also useful for per-probe warning suppression. We were discussing on IRC about emitting a warning for possibly uninitialized scratch variables
Attributes on maps seems like a great idea. Keeps lots of configuration options open for the future. And reusing language constructs where appropriate is always nice - less stuff for...
I don't really have an opinion yet but FWIW if this is only gonna be for function calls it's basically syntactic sugar. Front end can just transform `@x.contains(key)` into `contains(@x,...
Looks like if there are multiple targets in a config file and you also provide a command override via CLI, then all commands in the config will be overridden. I'm...
Hi! Sorry about the delay. I think we do want to support booting older kernels. I think wiring through some user-provided -cpu flags is appropriate. Thanks for checking.