Danny Brown

Results 89 comments of Danny Brown

@JustinTQ: https://github.com/cornerstonejs/cornerstone/issues/304#issuecomment-442268445 I don't believe we've landed on an official solution. This is something I feel comfortable leaving for a viewer to implement, but it appears to be a common...

Thanks, @mateusfreira! I've merged your fix. I'll likely need to generate a new `dist` and cut a release for the demo to start working, but the source is aligned. Thank...

@kofifus, if you submit a PR, I will take a look. @vdnsnkv, if you submit your example study, I can setup a test for it pre and post merge of...

I was caught a bit off-guard when I opened the example and saw 200+ enabled elements. @kofifus, if you have a fix you can PR, I'll test it against @vdnsnkv's...

Thanks for taking the time to PR the change, @kofifus. I'll post my results here, but may poke at the PR, as well as do some unit/performance testing.

RE: https://github.com/cornerstonejs/cornerstone/pull/363 Thanks again for your work on this @kofifus. It seems there is some room for improvement, but @jpambrun has highlighted more than a few use cases where `requestAnimationFrame`...

@gohabereg, are you able to author a PR that addresses this issue?

``` if (enabledElement.options.colormap) { console.warn('enabledElement.options.colormap is deprecated. Use enabledElement.viewport.colormap instead'); } ``` It looks like we removed `enabledElement.option` (undefined) And expect the colormap to live at `enabledElement.viewport.colormap` Our deprecation check...

I don't believe this project launches the chrome browser with any particular entrypoint. The `start:dev` script will watch for changes and update the output bundle as you develop. Most of...

Thanks for the bug report! A minimal reproduction would go a long way toward a quick verification. I am very open to a test case and PR for this.