Danny Kopping

Results 87 comments of Danny Kopping

Sorry, I'm a little sleepy :) I'm basically just restating what you initially suggested. What I mentioned above will basically make it a `Factory`-based architecture, which is exactly what's needed.

Interesting idea Markus I'm going to be looking closer at this on the weekend. Thanks!

Not yet completely fixed, although #13280 makes some progress towards it. Technically it does fulfil the requirements of the issue, but not the intent - I would venture.

@BrunoQuaresma I suspect this should be named _Provisioner Logs_ since that's what's being streamed into the logs section right now. I don't believe we have a mechanism to view the...

@BoBRoID thank you for reporting this; we're keen on adding compose support. We'll need to do some experimentation first, and I've added a new ticket https://github.com/coder/envbuilder/issues/135 to track that.

> I would like to see that some manual e2e tests are performed against example templates, at least Docker and Windows just so we're sure we don't break anything. I'm...

@mtojek thanks for taking a look! I'm going to look into this today and answer your questions.

Created https://github.com/coder/coder/pull/13408 so I can deploy this in the preview environment.

## Testing Linux Using the preview environment, I spun up a workspace with the kubernetes template. I shelled into the `coder` pod and replaced `coder-linux-amd64` with the following shell script:...

That's a cool idea @johnstcn 👍 Agreed it's out of scope for this PR. It's definitely in scope for the attached issue this PR is trying to fix, though, so...