pokered-gbc icon indicating copy to clipboard operation
pokered-gbc copied to clipboard

Minor clean up, Improve tileset palette assignments

Open JustRegularLuna opened this issue 1 year ago • 3 comments

  • This stops Polished Map from breaking colors, since Polished Map automatically trims any "unnecessary" tilepal entries from the end of the file when saving your changes.
  • Switched tileset palette sets and tilepal files to both be read from a pointer table, removing the need to INCLUDE them multiple times.
  • Uses a constant for the number of tiles in a tileset, to make things easier if a person decides to expand tilesets.
  • Fixes a hardcoded bank ID in oak_speech2.asm.
  • Adds some missing asserts in easy-to-miss tables from the color code.

JustRegularLuna avatar Jan 30 '24 23:01 JustRegularLuna

Actually hold off on merging this. My edited code only does $FF tiles and the original did $100. I'll fix that up tomorrow and update the PR.

JustRegularLuna avatar Jan 31 '24 06:01 JustRegularLuna

Ok, should be good now.

JustRegularLuna avatar Jan 31 '24 13:01 JustRegularLuna

There were a lot more duplicate Palette Sets than tilepal assignments, so I made those use a pointer table as well.

JustRegularLuna avatar Feb 01 '24 18:02 JustRegularLuna

The "one extra" entries in some tilesets was again because of polished map. Since it works off the gen 2 assumption that palettes are nybbles so it is trimming to an even number of tilepal entries

JustRegularLuna avatar May 09 '24 19:05 JustRegularLuna

The "one extra" entries in some tilesets was again because of polished map. Since it works off the gen 2 assumption that palettes are nybbles so it is trimming to an even number of tilepal entries

Hm, okay, that's not a big deal then. Thanks.

dannye avatar May 09 '24 22:05 dannye

No problem. I'll double check if there's a way around that, maybe loading it with the priority tiles setting in polished map or something (pretty sure that setting is unintentionally supported by pokered-gbc anyway).

JustRegularLuna avatar May 10 '24 13:05 JustRegularLuna

Thanks :-)

dannye avatar May 11 '24 00:05 dannye