pokered-gbc
pokered-gbc copied to clipboard
Minor clean up, Improve tileset palette assignments
- This stops Polished Map from breaking colors, since Polished Map automatically trims any "unnecessary" tilepal entries from the end of the file when saving your changes.
- Switched tileset palette sets and tilepal files to both be read from a pointer table, removing the need to INCLUDE them multiple times.
- Uses a constant for the number of tiles in a tileset, to make things easier if a person decides to expand tilesets.
- Fixes a hardcoded bank ID in oak_speech2.asm.
- Adds some missing asserts in easy-to-miss tables from the color code.
Actually hold off on merging this. My edited code only does $FF tiles and the original did $100. I'll fix that up tomorrow and update the PR.
Ok, should be good now.
There were a lot more duplicate Palette Sets than tilepal assignments, so I made those use a pointer table as well.
The "one extra" entries in some tilesets was again because of polished map. Since it works off the gen 2 assumption that palettes are nybbles so it is trimming to an even number of tilepal entries
The "one extra" entries in some tilesets was again because of polished map. Since it works off the gen 2 assumption that palettes are nybbles so it is trimming to an even number of tilepal entries
Hm, okay, that's not a big deal then. Thanks.
No problem. I'll double check if there's a way around that, maybe loading it with the priority tiles setting in polished map or something (pretty sure that setting is unintentionally supported by pokered-gbc anyway).
Thanks :-)