localbase
localbase copied to clipboard
dannyconnell
Added type files for typescript
Not sure how much complete this is, as I haven't worked on it since January.
@dannyconnell any chance than on your busy schedule you may look into that PR from @radio-miskovice? I'd love to contribute and expand eventually on @radio-miskovice 's work but I'd rather do it as a contribution than making it my own. Thanks.
@philippedasilva-orizone @radio-miskovice I'm not too hot on Typescript. If I pull this in, will it break anything for non-typescript users?
From what I see in the PR, @radio-miskovice is just adding type definitions using the standard javascript to typescript declaration pattern on a *.d.ts file which is then used by a) the typescript compiler and b) IntelliSense in general so it is not interfering with your actual codebase.
I however am not fund of having you accepting a PR without knowing if it is actually complete. I'll first have a quick test on my local instalment of localbase and add at least some additional validation. After all, as @radio-miskovice said, he worked on it in January and haven't touched it since then so he doesn't know if it covers the whole package or not ;)
Guys is this merged with master, Im currently integrating localbase on Angular 11, for time being i will check @radio-miskovice forked project and try installing, but it would be nice if you guys can merge it to the library once its properly tested.
@radio-miskovice thanks for working on the type files.
Sure. Sorry for the delay ☹
Jindřich Vavruška @.@.>
From: Lance @.> Sent: 8 November, 2022 20:54 To: dannyconnell/localbase @.> Cc: Jindřich Vavruška @.>; Mention @.> Subject: Re: [dannyconnell/localbase] Added type files for typescript (#38)
Can we slap this with good old merge?
— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdannyconnell%2Flocalbase%2Fpull%2F38%23issuecomment-1307752381&data=05%7C01%7C%7C4b9e930bc6e0458e474308dac1c2f4b2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638035340322028370%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=u5wiveW1%2BjiKPpXBnJFytJPa7Vxfb774zLDH6%2FaSx6Q%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABGUVWCDBPS2VCF7YUHTZZTWHKVU3ANCNFSM45NI5JMA&data=05%7C01%7C%7C4b9e930bc6e0458e474308dac1c2f4b2%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638035340322028370%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xTt05zxZD5A%2BqJLWGNaAYI3MaXVwEcgXRtokDhHGyjI%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.@.>>