Daniel Nilsson

Results 54 comments of Daniel Nilsson

Ping @mgiganto I think you maybe missed the revert in https://github.com/openwrt/luci/commit/05af14b25bc0fc2262416dcebf3360b11104198b, see https://github.com/openwrt/luci/issues/6902

I really like this idea. I assume you're waiting atm if https://github.com/openwrt/openwrt/pull/16656 gets merged and if it does rewrite it to use the `sysupgrade` command instead of creating a new...

I took at look at this problem and the reason is at least simple; [the protocol validate functionality reuses the name validate functionality](https://github.com/openwrt/luci/blob/master/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js#L1240), which means that if you create the...

I think I realized why it's probably set up that way, since if you enter an protocol + interface name combo which ends up less than the 15 character limit,...

> If you need me to test a fix let me know! @tiagogaspar8 If you're equipped to compile your own build from source, you could cherry-pick https://github.com/dannil/luci/commit/0fa2271e86d7f7e15a883bdc04ff1857332e19cd and see how...

> Hi @dannil, This seems to fix my issue, I changed the file on my router (so not a complete build), and I could add the second GRE interface as...

Just to clarify, is the `pause` function basically a way to temporarily disabling adblock as the blocklist is moved to somewhere else so the package just assumes to allow everything?...

Opening as draft as there's some cases I haven't tested yet if switching the check to prefix + interface name causes any problem. I also just noticed that `gre-abcdefgh1234567` is...

This proved a _bit_ harder than I first thought, since there doesn't seem to be any consistency for some virtual protocols in how they define their interface names, for example:...

~~We should if possible wait for @aparcar to verify this but seeing how firmware selector works as described in https://github.com/openwrt/luci/pull/7163#issuecomment-2176770355 I'm very sure this is how it's supposed to be...