Daniel W. Anner
Daniel W. Anner
This is in fact a bug in the tests, I can take a look at this soon hopefully. Sorry for the mess up
@lucatortiglione you can create a fork of this PR and then submit a new PR (and reference this one please). Otherwise no, unless he gives you access to his fork
@abhi1693 can you please let us know if you are going to work on this, and if not can you close it?
Closing this since it has been incomplete for a long period of time. Feel free to work on it then reopen it again if you would like.
Hello, my colleague and I use this codebase pretty often in our projects but the original and all forks seem to be stale. We have thus forked into our own...
The pickle files should not be committed or changed. Please remove those changes and make sure all test pass before marking this PR as ready to review
Hello, the pickle files should never be committed/merged manually. Pleased remove these files from your PR before marking this as ready to review. Thank you.
Closing this since it has been incomplete for a long period of time. Feel free to work on it then reopen it again if you would like.
The `weight` and `weight_unit` definitions should be available in the product datasheet. Can you please add those? Also add `airflow` if you can find if it is passive or directional....
@francesco-noc please resolve the conflicts or close this PR, thank you.