Dan Mayer comments

Results 150 comments of


                                            Dan Mayer

Redis CPU load is so high when using Coverband::ResqueWorker with a lot of resque jobs and RedisHashStore

yeah sadly the forking model adds a lot of overhead for collecting and reporting coverage as it is forked per job... You can see we have some specific integrations support...

Introduce Deferred Parent Cache Expiry

A few answers: * for the changelog, we can add a section that briefly covers adding a feature to avoid duplicate cache invalidation to this file https://github.com/Shopify/identity_cache/blob/main/CHANGELOG.md * since this...

Invalid route name, already in use `rails_service_blob_proxy` error at boot when upgrading to 6.1.2

hmmm I don't see why or what coverband would have to do with a blob proxy... * Did you restart spring after updating? * Are you all trying to use...

Invalid route name, already in use `rails_service_blob_proxy` error at boot when upgrading to 6.1.2

@gvarela any other details you can provide that might relate to this issue? I don't think I see the issue...

Invalid route name, already in use `rails_service_blob_proxy` error at boot when upgrading to 6.1.2

closing this as it hasn't been active and I never reproduced it

I18n tracking : manually mark an item as being used

I believe you can use the `ignore` config to match your translation keys... https://github.com/danmayer/coverband/blob/main/lib/coverband/collectors/abstract_tracker.rb#L130 try adding a string that would be a regex to some keys you want to ignore...

I18n tracking : manually mark an item as being used

hmm so if you are doing this manually ignore just means we won't try to report it as dead...but I get that isn't what you are looking for. I guess...

I18n tracking : manually mark an item as being used

I could do something like that but it would likely have to at least specify the view_tracker vs i18n or others trackers. that could be by method name or something...

I18n tracking : manually mark an item as being used

ok this feature was added int he linked PR.

Do not swallow `config.ignore` regexp errors

hmmm while I kind of agree with this we might need to hold it until a larger release version as I could see many folks having bad configs that they...