moodle-plagiarism_turnitin_danmarsden_old icon indicating copy to clipboard operation
moodle-plagiarism_turnitin_danmarsden_old copied to clipboard

A failure to talk to turnitin during cron breaks cron

Open mhughes2k opened this issue 11 years ago • 1 comments

I'm aware that this is being deprecated but for completeness, we've found that if turnitin can't be "read" during plagiarism_get_xml($url) call during the cron, the fact that it uses print_error() causes the whole cron script to die!

mhughes2k avatar Jan 15 '14 09:01 mhughes2k

yeah - I have wanted to rewrite a large chunk of that code for a while - The workflow was too reliant on events and made cron/event handling too fragile. originally I did it that way as the full file object was available in the event and it was easier to work with the file object than having to re-create it based on the params - but eventually we moved away from using the full file object in the event anyway - I think at some point it would have been good to make the event handlers just write to a new table and queue up all the required events in a seperate table which the Turnitin code would then parse - using the events in the way they are currently is a bit more fragile than I'd like.

I don't plan to work on this at this stage but feel free to submit a pull request!

danmarsden avatar Jan 15 '14 21:01 danmarsden