moodle-mod_attendance icon indicating copy to clipboard operation
moodle-mod_attendance copied to clipboard

Activity Names Auto Linking

Open shmevan18 opened this issue 2 years ago • 16 comments

The activity names auto-linking feature only works on the calendar view. Can this feature be added to the Sessions Views? I use the session description to display activities that are due on that day as Auto Links, which is great in calendar view. Would be very useful to also have this in the table formatted views that the attendance module generates.

shmevan18 avatar Jul 28 '22 16:07 shmevan18

sure - pull requests are always welcome, otherwise I'll try to remember to come back to this sometime.

danmarsden avatar Jul 29 '22 07:07 danmarsden

That's above my paygrade to work on 🙃

shmevan18 avatar Aug 04 '22 13:08 shmevan18

Hi Dan, Thanks for looking into this! I forwarded this over to our tech support team at Moodle to update the module. I am not seeing that it has fixed the issue though. Was that code included in the latest update (an assumption that the dev team made when updating the module for us)?

shmevan18 avatar Oct 10 '22 15:10 shmevan18

it's in the versions for Moodle 3.11 and higher - so if you're using an older Moodle release it won't be there.

danmarsden avatar Oct 25 '22 20:10 danmarsden

We are on moodle workplace 3.11.9

shmevan18 avatar Oct 25 '22 20:10 shmevan18

The correct version of attendance for that version should be 3.11.16 (2021082609) which should have this fix. If not then there's somewhere else missing the code required, - please add screenshots of both your filter settings page and the exact location where the filtering is not running.

danmarsden avatar Oct 25 '22 21:10 danmarsden

Confirmed version 3.11.16 [image: image.png] [image: image.png] Items marked in red are what I expect to be autolinked. They do work in the calendar view.

On Tue, Oct 25, 2022 at 5:15 PM Dan Marsden @.***> wrote:

The correct version of attendance for that version should be 3.11.16 (2021082609) which should have this fix. If not then there's somewhere else missing the code required, - please add screenshots of both your filter settings page and the exact location where the filtering is not running.

— Reply to this email directly, view it on GitHub https://github.com/danmarsden/moodle-mod_attendance/issues/603#issuecomment-1291153140, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYFGGVWCHFY3OXS656QOYUTWFBEYTANCNFSM5453PBGA . You are receiving this because you authored the thread.Message ID: @.***>

shmevan18 avatar Oct 26 '22 15:10 shmevan18

image image

shmevan18 avatar Oct 26 '22 15:10 shmevan18

thanks that helps a lot - I'll take another look to see where else the filter process isn't kicking in as expected.

danmarsden avatar Oct 28 '22 05:10 danmarsden

I'm pretty sure I've fixed that properly this time - I've pushed the fix into the 3.11 and higher branches here in github - I'm hoping to look at a few other issues before I push that out to the plugins db, but hopefully that will happen soon! - thanks for the help! :-)

danmarsden avatar Oct 28 '22 06:10 danmarsden

It now works as expected! Thank you so much for your efforts!!

shmevan18 avatar Nov 17 '22 01:11 shmevan18

CORRECTION!! I spoke too soon! It does not appear to work from the student side. A student reported this to me after announcing it should work. I changed my role to Student and the links do not show.

shmevan18 avatar Nov 17 '22 02:11 shmevan18

Hi @shmevan18 - are you referring to the "All sessions" view/tab? - that's the only place I've been able to find that doesn't filter it correctly so far.. - maybe add a screenshot of what the student sees?

danmarsden avatar Nov 25 '22 00:11 danmarsden

First image is of the student view of All Sessions in the attendance. Second picture is the teacher's view. Autolinking not displaying on the student side. image image

shmevan18 avatar Nov 27 '22 17:11 shmevan18

Hi, any update on this?

shmevan18 avatar Jan 13 '23 02:01 shmevan18

haven't had a chance to look again. It's in the list, but might take some time before I come back to this. - thanks!

danmarsden avatar Jan 15 '23 20:01 danmarsden