moodle-local_recompletion
moodle-local_recompletion copied to clipboard
new notification settings to determine which users get a recompletion…
replaces PR #161
When looking at the new option in the form - I didn't like the relation between the 2 settings - recompletionemailenable and recompletionnotify and decided we only needed one form element for that option - your new one "recompletionnotify" with the top option being "disabled"
I also thought we should hide the field completely when the recompletion type is set to "disabled".
I've added upgrade and restore steps, but haven't tested these and I haven't tested notifications from this new code yet either so it's possible I've missed something while making those changes.
@davidpesce any chance you could do a peer review/test the updated code before we look to merge this into the repo?
thanks!
Sorry for the delay on this, @danmarsden
PR looks good to me and I like your thinking/design! This should be good to merge