cppcheck icon indicating copy to clipboard operation
cppcheck copied to clipboard

fixed #8659 - aligned contents of all install packages

Open firewave opened this issue 1 year ago • 2 comments

firewave avatar Oct 11 '24 16:10 firewave

It is impressive how often things coincide...

firewave avatar Oct 11 '24 17:10 firewave

@danmar What is the point of compiling misra.py and not distributing it?

It is included in the portable package but I guess that was not intentional. But that might not even work - see below.

But including this causes the installer to blow up in side because the binary requires the Python libraries to be included as well. And I am not sure if that affects something regarding licensing (beside adding the Python license).

firewave avatar Oct 18 '24 15:10 firewave

What is the point of compiling misra.py and not distributing it?

I made a "half hearted" attempt to distribute a misra addon that does not require python. We had a premium customer that didn't want to install python.

I feel uncomfortable about distributing the compiled misra addon I see it as untested. If a customer really wants it and understands that I didn't test it properly but still wants to use it well I can let the customer test this.

I think that for 99% of the customers it is OK to install python.

If we remove the extra code from release-windows.yml that is fine for me.. but it would be nice if I had some way to build the compiled misra addon in some github action somewhere.

danmar avatar Dec 12 '24 10:12 danmar

If we remove the extra code from release-windows.yml that is fine for me.. but it would be nice if I had some way to build the compiled misra addon in some github action somewhere.

I still included it in the portable package so it can be tested.

firewave avatar Dec 12 '24 12:12 firewave

The commit in cli/CMakeLists.txt breaks some builds. See for example https://github.com/OSGeo/gdal/actions/runs/12298084801/job/34320720920 :

Install the project...
-- Install configuration: "Release"
-- Installing: /usr/local/bin/cppcheck
-- Installing: /usr/local/bin/cppcheck-htmlreport
CMake Error at cli/cmake_install.cmake:78 (file):
  file INSTALL cannot find
  "/home/runner/work/gdal/gdal/cppcheck/cli/RUNTIME": No such file or
  directory.
Call Stack (most recent call first):
  cmake_install.cmake:50 (include)

with the cppcheck build being done at https://github.com/OSGeo/gdal/blob/master/.github/workflows/code_checks.yml#L68

rouault avatar Dec 12 '24 14:12 rouault

I had a feeling I still wanted to do something in this PR - add tests for the install to the CI.

I can reproduce it locally and I am on it.

firewave avatar Dec 12 '24 18:12 firewave

I have a fix - PR will go up in a few minutes.

firewave avatar Dec 12 '24 18:12 firewave

See #7100.

firewave avatar Dec 12 '24 19:12 firewave