removed `ErrorLogger::reportProgress()` and command-line option `--report-progress`

[firewave]

As detailed in https://github.com/danmar/cppcheck/pull/4985#discussion_r1171846635 it doesn't provide much progress and adds unnecessary complexity to the ErrorLogger and CppcheckExecutor.

We should probably remove TokenImpl::mProgressValue as well.

[firewave]

As a fix for the democlient it should possibly perform a delayed call to Settings::Terminate() instead which should provide a similar behavior.

I am also open to keeping the option and nop'ing it for now and provide a much better progress implementation later on.

[firewave]

This approach goes probably a bit too far. I will revise the changes.

[danmar]

as I said.. we have reasons to keep this. maybe you can consider using the reportProgress instead.

[firewave]

Yes, this goes in hand with #5288 and https://trac.cppcheck.net/ticket/11248 as it is about progress indication as well as providing interruption points for cancellation (especially if not using threads instead of processes).

Maybe this could even be addressed with the current executor rework I am doing.

[firewave]

I will file a ticket about this in the next few days.

[firewave]

Seems there already was a ticket about this: https://trac.cppcheck.net/ticket/3450. I also came to some of the same conclusions before even reading it.