cppcheck icon indicating copy to clipboard operation
cppcheck copied to clipboard

Patch from the conan center index recipe

Open MartinDelille opened this issue 3 years ago • 2 comments

Here are two patch that lives in the conan center index recipe.

Tell me if it is relevant of if it need some further improvements.

MartinDelille avatar Sep 02 '22 13:09 MartinDelille

The changes look fine but somewhat arbitrary since the version-less Python shebang and CMAKE_SOURCE_DIR are still used all over the place. So some context what this is fixing specifically would be very helpful.

FYI #3812 has the shebang changes as a whole but unfortunately it appears it was abandoned by the author.

firewave avatar Sep 02 '22 13:09 firewave

I revert the python version related commit.

MartinDelille avatar Sep 24 '22 11:09 MartinDelille

I just rebase this PR against the main branch.

MartinDelille avatar Nov 11 '22 11:11 MartinDelille

Thanks, but you still didn't explain what problem this is fixing.

firewave avatar Nov 11 '22 14:11 firewave