oce icon indicating copy to clipboard operation
oce copied to clipboard

Can the nortek aquadopp "orientation" field change during a deployment?

Open richardsc opened this issue 3 years ago • 12 comments

Following on from https://github.com/dankelley/oce/issues/1758#issuecomment-745566119

Oh, and I see the "orientation" field IS there, it's just been renamed to be orientation, rather than configTiltSensorOrientation ...

    if (missing(orientation)) {
        orientation <- header$head$configTiltSensorOrientation # FIXME: is there a 'header$head'?
    } else {
        orientation <- match.arg(orientation, c("sideward", "upward", "downward"))
    }

One concern I have about this (which was an issue with RDI instruments, I believe), is that we are treating this field as a constant for the entire file, whereas it may actually vary depending on how the orientation changes. For example, if the instrument was lying on its side on deck before deployment, it might register that as "downward" even if it ends up deployed in an "upward" position. I'd better open a separate issue for this (and debug by checking the instrument logs, which I'm waiting for from our field group).

richardsc avatar Dec 15 '20 21:12 richardsc

This issue has been automatically marked as stale because no comments have been made in two weeks. Unless comments are made in the next week (or the 'pinned' label is applied), this issue will be closed automatically in a week.

stale[bot] avatar Dec 31 '20 20:12 stale[bot]

Slow down stale bot -- it's the holidays!

richardsc avatar Jan 01 '21 04:01 richardsc

I just doubled both time criteria.

dankelley avatar Jan 01 '21 10:01 dankelley

A reminder: I'll need a sample file. (To prevent concern over missing-mail problems, please note that I'll email back when you send it.)

dankelley avatar Jan 22 '21 11:01 dankelley

Sent.

richardsc avatar Jan 22 '21 13:01 richardsc

This issue has been automatically marked as stale because no comments have been made in two weeks. Unless comments are made in the next two weeks (or the 'pinned' label is applied), this issue will be closed automatically in a week.

stale[bot] avatar Jun 11 '21 02:06 stale[bot]

Removing the stale label, as I am waiting for @dankelley to have a look at the sample file that I sent. There isn't a big rush for this, but it probably shoudn't just disappear.

richardsc avatar Jun 11 '21 14:06 richardsc

I imagine you knew I was going to ask this, but can you resend the sample file? I don't track emails well (by which I mean that I delete old emails aggressively), and unless I put files into a subdirectory in the oce-issues repo, I don't know where to look. I tried as below (guessing a filename from #1758) but got no hits.

find ~ -name 205413.AQD -print

dankelley avatar Jun 11 '21 17:06 dankelley

Sent (again 😄 ). Filename is aqd9330.aqd.

richardsc avatar Jun 11 '21 17:06 richardsc

This issue has been automatically marked as stale because no comments have been made in two weeks. Unless comments are made in the next two weeks (or the 'pinned' label is applied), this issue will be closed automatically in a week. Please note that this is not a reflection on the quality or importance of the issue, but merely a reminder of the march of time. A simple comment is all it takes to keep this issue from being closed automatically, two weeks from now.

stale[bot] avatar Jul 21 '21 00:07 stale[bot]

I'm commenting to keep this issue alive. I keep forgetting about it, sorry.

dankelley avatar Jul 21 '21 09:07 dankelley

An automated message from the stale bot -- this issue has been marked as stale because no comments have been made in 30 days. The goal of this action is to remind reporter and developers alike that progress seems to have stalled. Please note that the issue will be automatically closed 30 days from now, unless a comment is made, or the pinned label is applied. Thank you.

stale[bot] avatar Apr 17 '22 04:04 stale[bot]