Dan Kelley

icon indicating a website link https://dankelley.github.io/dek_blog/ icon indicating an email [email protected]

icon company Dalhousie University icon location Halifax, NS, Canada icon location Oceanographer, University Professor and former Senator (ORCID https://orcid.org/0000-0001-7808-5911)

Results 76 comments of Dan Kelley

tidem() and t_tide do not produce identical results

I dumped the CR zipfile into https://github.com/dankelley/oce-issues/tree/master/16xx/1653/cr and excerpted the table comparing results into https://github.com/dankelley/oce-issues/blob/master/16xx/1653/dk/1653dk_01.R so I could look in more detail. That R script has enough comments to explain,...

need CRAN submission re text encoding

Hm. `devtools::check_win_devel()` does not report errors, but maybe it needs a day or two to get an update.

need CRAN submission re text encoding

Hi Dan, I've just committed a change to R-devel which makes sub/gsub/strsplit return a result marked as `"bytes"` when non-ASCII and using bytes (so when one of the inputs is...

need CRAN submission re text encoding

~**GOOD NEWS** as of this morning, `devtools::check_win_devel()` now reports an error. That means I won't have to rely on `rhub` being restored to full power (which has no stated timetable...

need CRAN submission re text encoding

Um, re the "GOOD NEWS" from yesterday, R-devel has been reverted a bit, so it only produce diagnostics if env-var ``` _R_REGEX_MARK_NEW_RESULT_AS_BYTES_=TRUE ``` is set. That's fine for local builds,...

need CRAN submission re text encoding

Now get successful build-check-install with the "encoding2" branch, commit 1b7647e99c405e75fe925ec964b102f69a7017f4, with R-devel as of earlier today, using ``` _R_REGEX_MARK_NEW_RESULT_AS_BYTES_=TRUE R CMD build --compact-vignettes="qpdf" oce _R_REGEX_MARK_NEW_RESULT_AS_BYTES_=TRUE R CMD check --as-cran oce_1.7-9.tar.gz...

need CRAN submission re text encoding

I plan to merge "encoding2" into "develop" early tomorrow morning. I just don't like having too many branches in-play at once, because merge conflicts are a waste of time. Also,...

need CRAN submission re text encoding

I have merged "encoding2" into "develop". It will make sense for all users to be on the lookout for problems with this. This should only affect text-based files, so not...

need CRAN submission re text encoding

Today I got a reminder to resubmit by Aug 30. The error (below, item 1) now is different from before, but I think still related to encoding. I tried using...

need CRAN submission re text encoding

`rhub::check_for_cran()` will report at the following (a check means it was OK, perhaps with comments at the end). * [x] https://builder.r-hub.io/status/oce_1.7-9.tar.gz-49a6cb1d3abd4195a4b79bc0afca6896 * [x] https://builder.r-hub.io/status/oce_1.7-9.tar.gz-623400129a714582b45cec60ad5948cf * [x] https://builder.r-hub.io/status/oce_1.7-9.tar.gz-4d79f6b2112b4f6b9d20ef1556a06ff1 * [x] https://builder.r-hub.io/status/oce_1.7-9.tar.gz-23dabd1b450348b4b1c02f556093a2d7