Daniel Hutzel

ping

Hi Gregor, I recently looked at it but found that you updated the models? For the original models (Order.csn) that would have helped to simply exclude those entities containing SQL...

Hi Gregor, yes that's the other error, irrelated to the SQL keywords issue, which has to be fixed by the compiler relaxing on entity definitions without elements (as indicated by...

Our code explodes ... wonder if we could do that better. Maybe it's due to how getTransitions() works. Btw: using these private helpers from @sap/cds is no good.

I don't get the conclusion. Is it that you can't use result values you got of min/max(x) as values for subsequent queries with where x=? If yes: yes, that's true...

I'd also just keep it as it is → we always log under `sql`, which makes it easier as compared to the past. Note that the alternative ids specified after...

Some more observations below, using this generated query out of `INSERT.into(Books,{title:'t'})`: ```sql INSERT INTO sap_capire_bookshop_Books ( createdAt, createdBy, modifiedAt, modifiedBy, ID, ... ) SELECT ( CASE WHEN json_type(value, '$."createdAt"') IS...

Why are we quoting names in JSON path arguments? → i.e. ```sql SELECT value ->> '$."ID"', value ->> '$."title"', value ->> '$."descr"', ... ``` could be: ```sql SELECT value ->>...

Superfluous `(...)`: ```sql SELECT ( CASE WHEN json_type(value, '$."createdAt"') IS NULL THEN session_context('$now') ELSE value ->> '$."createdAt"' END ), ... ``` → ```sql SELECT CASE WHEN json_type(value, '$."createdAt"') IS NULL...

Before this PR the following expressions were used for `createdAt` ```sql COALESCE ( ISO(value ->> '$.createdAt'), session_context('$now') ) ``` Now it's this: ```sql CASE WHEN json_type(value, '$.createdAt') IS NULL THEN...