Kévin Danielo

Results 13 comments of Kévin Danielo

I have no plan to work on this topic at the moment but feel free to open a PR.

@pupudu Thanks! Keeping this issue open is fine for me! I started to work a bit on adding TS definitions, but I don't have a lot of experience on TS...

Update ```ts interface RelationshipOptions { type: string; alternativeKey?: string; schema?: string; links?: ((data: object, extraData: object) => object) | object; meta?: ((data: object, extraData: object) => object) | object; deserialize?:...

@stefanvanherwijnen Thank you for your feedback **Update:** ```ts interface RelationshipOptions { type: string; alternativeKey?: string; schema?: string; links?: ((data: { [key: string]: string }, extraData: any) => { [key: string]:...

@diosney what about having just a check on `id` like this: ```javascript if (data.id !== undefined) { deserializedData[options.id] = data.id; } ``` instead of: https://github.com/danivek/json-api-serializer/blob/e346ab5d13e95ac21460255f65d4094e20971984/lib/JSONAPISerializer.js#L380 So if you would not...

Yes, you can't actually directly serialize relationship data. Maybe you can get around this by serializing primary data and picking relationship data and `includes` from the result. The idea of...

@noetix, great addition 👍 But actually, I can't know if "include" parameter has been requested or not regarding data (Maybe I'm missing something). Maybe 2 possible ways: 1. Adding a...

You're right, it's much better than `true`, but it could be more complicated if you have such deep path `{ 'include': ['comments.user.roles'] }` to filter. I always thought that, for...

I made a quick try of whitelisting includes with such `include: ['articles.comments.author']` option on branch [include-filter-test](https://github.com/danivek/json-api-serializer/tree/include-filter-test) Seems to be not as complex as it is. @noetix, could you make a...