Danish Arora

Results 77 comments of Danish Arora

passkeys look pretty cool! a POC would be fun --- on a side note: since they are quite new, how do you think about the education + onboarding part should...

Only Store remains from this issue. Moving back to TODO as this is low priority. Might address it with #1685

> @danisharora099 changes done. Correct me if I am wrong but I think some exports like waku_filter, waku_store and few others are not used currently. Rest I have changed. @varunsh20...

Hi @varunsh20 are you still interested in this PR? If not, we can close it.

sounds good -- let's confirm the scope of this issue before we move forward. @waku-org/js-waku-developers are we deciding to stick with camel case? also related: our file names are done...

@varunsh20 I had left a review on your PR https://github.com/waku-org/js-waku/pull/1934#issuecomment-2044647535

Hey @varunsh20 are you still interested in addressing comments on the PR? Mostly seems good, just need to ensure CI passes.

> @danisharora099 thanks for the comments, I propose to have those that are actionable as follow ups Let's address the non-nit ones that are more important such as: not redefining...

> To maintain adherence to the sharded format, the lightpush client API should be updated. > New proposed format: lightPublish(WakuMessage, ClusterID, ShardNumber) > For legacy requests on named topics, the...