django-comments-xtd icon indicating copy to clipboard operation
django-comments-xtd copied to clipboard

even if "COMMENTS_XTD_CONFIRM_EMAIL = False", form still shows: "Required for comment verification"

Open ghost opened this issue 7 years ago • 3 comments

I use the available option in settings COMMENTS_XTD_CONFIRM_EMAIL = False since I'm doing only a post-posting validation of the comments, not a pre-posting one.

It's working great.

Still, the comment form still displays at the Email section: Required for comment verification.

It's a minor bug but think it's a bit confusing for the poster since it should display something like: Required for follow-up notification for example.

ghost avatar Dec 05 '18 05:12 ghost

Just a clarification that I'm not sure I did in the docs. The mail field is still displayed for a logged in user when the particular user doesn't have a registered email address. If you go to the admin site and provide one then it's not displayed.

Apart from that, I do agree, the message must be different. It's just a matter of adding an if in the templates (and in the React code) to show "Required for follow-up notification" when the user is logged in.

Do you feel like doing it?

danirus avatar Dec 05 '18 08:12 danirus

I will look into it (never worked with ReactJS but it doesn't seem too complicated...)

ghost avatar Dec 06 '18 12:12 ghost

Sounds good. If you have any trouble just create a pull request and we work together on it.

danirus avatar Dec 06 '18 12:12 danirus