graph-cut-ransac icon indicating copy to clipboard operation
graph-cut-ransac copied to clipboard

Support float/double image width and height

Open Parskatt opened this issue 2 years ago • 1 comments

Hi,

Currently the python wrapper, see e.g. here:

https://github.com/danini/graph-cut-ransac/blob/37f7469d49dbedddeaa5a2c1427b70121375c0bd/src/pygcransac/src/gcransac_python.cpp#L721-L731

only supports integer image sizes.

As far as I can tell, these are always cast to doubles, so it would make sense to support arbitrary numbers.

In my use case I have modified the intrinsics, and hence the "virtual" image sizes become doubles. I'm unsure if rounding these to integers pose any issues to the RANSAC loop, so would prefer to insert the exact values.

Although reading the code it seems these only control neighbourhood sizes so I guess rounding shouldnt be a big issue.

Best, Johan

Parskatt avatar Dec 06 '22 12:12 Parskatt

Rounding should not cause any problem I think. The sizes are only used for specific samplers and for the neighborhood calculation.

danini avatar Jul 04 '23 08:07 danini