yas3fs icon indicating copy to clipboard operation
yas3fs copied to clipboard

Refactor code from __init__.py

Open pstoll opened this issue 8 years ago • 1 comments

YAS3FS is an impressive piece of work so I hate to suggest something that might come across as something less than praise but... having almost the entire codebase inside a 3k line init.py file seems a little ... unusual.

Have you given any thought to breaking that out into separate files? Would you be open to folks working on something like that?

pstoll avatar Mar 30 '16 01:03 pstoll

Hi Perry,

I think you're right and it is due to poor planning on my side.

The project started as a proof of concept to test the advantages of caching compared to the more traditional s3fs approach.

Then I kept it as a single file to make it easier to share with a single link, but since it was packaged to be distributed via pip that doesn't make sense anymore.

I have no time to invest on this project, but I am more than happy to add contributors to enhance and refactor it.

On Wed, Mar 30, 2016 at 3:24 AM, Perry Stoll [email protected] wrote:

YAS3FS is an impressive piece of work so I hate to suggest something that might come across as something less than praise but... having almost the entire codebase inside a 3k line init.py file seems a little ... unusual.

Have you given any thought to breaking that out into separate files? Would you be open to folks working on something like that?

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/danilop/yas3fs/issues/123

danilop avatar Mar 30 '16 12:03 danilop