ServerlessByDesign icon indicating copy to clipboard operation
ServerlessByDesign copied to clipboard

Separate dependencies from JS/CSS code

Open alexcasalboni opened this issue 6 years ago • 4 comments

I would make clear what is a library/dependency and what's part of the repo. Eventually, we could add a bit of dependency management and injection (npm, bower, browserify, gulp, webpack, etc.).

alexcasalboni avatar Sep 11 '17 07:09 alexcasalboni

I agree, the reason I included the source JS/CSS files for the dependacies was that I still wanted people to be able to clone the repo and start using it locally, without having to use a too such as npm/bower to install the dependencies.

danilop avatar Sep 11 '17 11:09 danilop

I like that everything needed to use the tool was available locally. I do a lot of programming on trains/buses with intermittent internet.

fblecha avatar Sep 11 '17 12:09 fblecha

PR #2 adds in browserify which I suggest is a good middle ground. If we upload bundle.js (as the PR does) then it's ready to run locally without any additional commands as soon as the user clones it, but we still get the modularity of browserify (which I used to avoid name collisions between the engines).

rts-rob avatar Sep 11 '17 12:09 rts-rob

@fblecha @rts-rob I'm not necessarily suggesting to use CDNs for external libraries. I am suggesting to remove them from the repo and use a proper dependency management tool. This way, you'd only install dependencies once at clone-time. Also, we'll be able to update libs versions over time without manually copying huge files.

alexcasalboni avatar Sep 11 '17 13:09 alexcasalboni