Danilo Leal
Danilo Leal
Not sure I'd go for a video—maybe a GIF would be better, so it's much, much faster. And totally agree with the code needing to be meaningful to the illustration....
Okay... might have messed up things a bit... 😅 Ended up forcing pushing it as new commits were added after I had already committed stuff (but before I had pushed...
Just realized that the styles we added to make the tabs fit nicely within a demo container break them when in a standalone tabbed code block. For example, the installation...
@bharatkashyap is there anything I can do to help this PR move forward? 😃
Looks great to me! I only noticed that the borders on the code block/editor and the demo toolbar are a bit funky—they appear and disappear depending on the mode/tab selected....
@EyaOuenniche sure, yeah! Feel free to kickstart it and ask for a review :) Let me know if you need any help, and I can give you pointers!
@EyaOuenniche hey there! The Fade page linked in the issue is just one illustrative example — the correct approach would be to change in a place where the entire documentation...
Good catch! The marketing pages' implementation of the menu is already using Popper, and it seems to suffer from a similar problem, too — you can't even focus the first...
Quick bump on this one — quality-of-life type of update! 👍
I've also seen somewhat similar stuff with `t` being used for `translation`: https://github.com/mui/material-ui/blob/657705633bbcf85019aa8bbf16d143a0d304edfe/docs/data/material/components/material-icons/SearchIcons.js#L263 Should we think of it similarly?