daydreamer icon indicating copy to clipboard operation
daydreamer copied to clipboard

set gripper speed 10000 may break gripper

Open k-ish0212 opened this issue 2 years ago • 3 comments

Thank you for sharing the code!

We are testing this repository's xArm part too, but we noticed xarm-python-SDK have some problems. In this code, gripper speed was set to 10000, but the actual maximum speed is below this value. The problem is that xarm-python-SDK seems not set upper thresh of gripper speed so it may cause unknown behavior. https://github.com/danijar/daydreamer/blob/709016ce11c32dad1f24c4cc77afdf980d2a92a8/embodied/envs/other.py#L265 We found it is better to set around 4500.

k-ish0212 avatar Dec 27 '22 18:12 k-ish0212

Thanks for sharing! Is this just to hide the warnings or does the robot actually behave better in some way?

danijar avatar Dec 28 '22 10:12 danijar

Hi,

It doesn't cause any errors, or even warnings, but the gripper started making strange noise after few hours of training. Then we found that the gripper speed was set higher than the maximum.

tatsukamijo avatar Jan 15 '23 16:01 tatsukamijo

Haha we noticed a strange noise too, that may be the reason. Thanks!

danijar avatar Jan 15 '23 17:01 danijar