Danijar Hafner comments

Results 165 comments of


                                            Danijar Hafner

Line breaking behavior for function arguments with and without trailing comma

@gwelymernans Thanks, that works except for the second example, where the closing parenthesis should not have its own line: ``` python a_very_long_function_name( long_argument_name_1=1, long_argument_name_2=2, long_argument_name_3=3, long_argument_name_4=4) ```

Line breaking behavior for function arguments with and without trailing comma

Thank you!

Line breaking behavior for function arguments with and without trailing comma

Why did you remove this functionality with your newest commit https://github.com/google/yapf/commit/311c08719451a0cdc3a578b360293ffabb28e0d6?

Line breaking behavior for function arguments with and without trailing comma

Yes, this behavior would be very nice, including the breaking before the first argument in the third example but that might be an unrelated concern.

Line breaking behavior for function arguments with and without trailing comma

I think this makes only sense for lists. For single-element tuples, the trailing comma is not formatting but syntax.

Line breaking behavior for function arguments with and without trailing comma

Would be perfect, thanks.

Error when using env.render() along with stable-baselines3

Thanks! I'll leave this open in case it's helpful for other people. I don't know if updating the env is worth it at this point since OpenAI seems to have...

Enviroment stepping for faster than real time simulation

Running into the same issue here. It's surprising because robosuite uses the same mujoco version as dm_control, but dm_control runs over 3x faster with rendering enabled than robosuite does without...

Chapter 6?

I also have a gist for a char-rnn in TensorFlow that works very similar to the one described in the book: https://gist.github.com/danijar/c70e7f7811231ce0cecceea76d07ffed