Daniel Weck

Results 1800 comments of Daniel Weck

I already posted a couple of comments (see above, inlined in this discussion thread). However, there are a number of non-translated strings (still in English). Does this mean this PR...

Thank you for reporting this! The current code incorrectly matches same-language locales (e.g. `fr` vs. `fr_FR` vs. `fr_CA`, or `en_US` (which is the default) vs. `en_GB`). Furthermore, the underscore syntax...

To recap: when the Readium cloud/web reader opens exploded / unzipped EPUBs, only the HTML documents are loaded as "blobs" into the host iframes (with their respective origin set via...

The functionality you are describing is currently not implemented, but you can of course replace the LocalStorage code with an alternative method. There is currently no "extensibility" API to introduce...

I just tried with https://readium.firebaseapp.com (which is `readium-js-viewer`, which itself is based on the same `readium-shared-js` code as native iOS / Android reader apps). Everything looks okay in both scroll...

I suspect this problem occurs because of how Readium applies the font-size change to DOM fragments: https://github.com/readium/readium-shared-js/blob/develop/js/helpers.js#L256 Applying a percentage value at the top-level does not work in many cases...

Thanks for the tip! https://developer.mozilla.org/en-US/docs/Web/CSS/text-size-adjust

oh, that's a new bug! :( Is this actually a failing "page turn" _inside_ a reflowable document (i.e. transition from one CSS column to the next), or a failure to...

Ah, that's annoying. I was testing reflowable page turn with Media Overlays recently, and I did not observe this bug. Thanks Alberto.

Specifically: https://github.com/readium/readium-js-viewer/blob/master/epub_content/idpf_samples.opds https://github.com/readium/readium-js-viewer/blob/master/epub_content/epub_testsuite.opds https://github.com/readium/readium-js-viewer/blob/master/epub_content/epub_tests_a11y.opds ...and some in here too: https://github.com/readium/readium-js-viewer/blob/master/epub_content/epub_library.opds