Daniel Turek

Results 107 comments of Daniel Turek

@crvernon No problem: - Created review checklist for @matt-graham - Created review checklist for @larryshamalama - @matt-graham did (what seems like) a fairly careful review of the [nimbleHMC repository](https://github.com/nimble-dev/nimbleHMC) -...

@crvernon I've made a number of revisions in response to constructive review comments from @matt-graham. I wanted to check-in regarding status of review from @larryshamalama, in hopes of continuing to...

@crvernon I've addressed the additional comments, with details below. And thank you to @larryshamalama for the additional review. - Fixed [issue 67](https://github.com/nimble-dev/nimbleHMC/issues/67), by updating the examples in the roxygen in...

@paciorek Noting that there does **not** exist a manual example which would fail, on account of this. In "Section 12.2 User-defined distributions", both `dmyexp` and `rmyexp` are defined (as well...

@paciorek Given that (a) it's a minor release, (b) this is protected behind an option, and (c) this is a useful improvement, I would vote to include it. Furthermore, it's...

@perrydv Only addressing your comment about `parameterTransform` and multivariate user-defined distributions. I just checked, and those changes (addressing this issue) appear to still be on branch `transform_user_dist`, which is not...

My previous comment was intended for NCT issue 567, and has been repeated there.

Agreed that these cases need some attention. My initial thought would be to error-trap any of these non-standard cases: when anything other than a single, univariate sampler, is operating on...

Addressed in PR #1475. @paciorek In regard to your question: we previously *already did* handle the case of "the target node has two samplers (either two univariate or one univar...