Daniel Tartaglia

Results 42 comments of Daniel Tartaglia
trafficstars

Sorry, but the code posted is not self-contained. Please update the code to a self contained example that exhibits the problem?

The issue with this code is here with the ViewModel class. You made it Hashable. It doesn't make sense to put a BehaviorRelay in a Hashable type. The diffable data...

I understand it has to be Hashable, but you *cannot* put a BehaviorRelay in a Hashable type. It doesn't make any sense. Additionally, you are not creating your Hashable type...

I have not seen any issues with `DispatchQueue.isMain` in the code you have provided.

Where are you putting the breakpoint?

I see it now. It feels like the "DispatchQueue+Extensions.swift" file needs to be changed to: ``` extension DispatchQueue { static var isMain: Bool { Thread.current.isMainThread } } ``` But I'm...

I believe this is a mistake in the documentation. The observable passed into `take(until:)` will only terminate the source on an onNext or onError event, not for onCompleted. This is...

Exactly what file are you talking about with incorrect documentation? I invite you to submit a pull request with the file corrected.

> Again, why not merge, I need to use this operator now @danielt1263 I don't think I have control over when this gets merged. Maybe @freak4pc could chime in here?