potter-db icon indicating copy to clipboard operation
potter-db copied to clipboard

Translations added: Portuguese (Brazil)

Open cnfranco opened this issue 1 year ago • 8 comments

I translate the documentation to Portuguese (Brazil).

  • [x] This pull request has a meaningful title and description.
  • [x] I have read and followed the Contributing guidelines.
  • [x] My code follows the conventions and coding style of this project.
  • [x] All tests pass and I have added tests for my changes
  • [x] I have updated necessary documentation

cnfranco avatar Oct 23 '23 14:10 cnfranco

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
potter-db-docs ✅ Ready (Inspect) Visit Preview Dec 7, 2023 1:36pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
potter-db ⬜️ Ignored (Inspect) Visit Preview Dec 7, 2023 1:36pm

vercel[bot] avatar Oct 23 '23 14:10 vercel[bot]

This PR doesn't seem to be finished.

danielschuster-muc avatar Oct 24 '23 17:10 danielschuster-muc

Can I help you with anything @cnfranco?

danielschuster-muc avatar Oct 30 '23 21:10 danielschuster-muc

This PR doesn't seem to be finished.

Yes, it wasn't finished, but I added the latest translations throughout this week. However, I am unable to correct the following check error (image attached).

potter

Could you see what could be causing this?

cnfranco avatar Oct 31 '23 17:10 cnfranco

This PR doesn't seem to be finished.

Yes, it wasn't finished, but I added the latest translations throughout this week. However, I am unable to correct the following check error (image attached).

potter

Could you see what could be causing this?

Failed to compile.

17:12:17.916 |   17:12:17.917 | ./theme.config.tsx:99:190 17:12:17.917 | Type error: Property assignment expected. 17:12:17.917 |   17:12:17.917 | 97 | </> 17:12:17.917 | 98 | ), 17:12:17.917 | > 99 | i18n: [{ locale: "en", text: "English" }, { locale: "fr", text: "Français" }, { locale: "es", text: "Español" }, { locale: "sk", text: "Slovenčina" }, { locale: "de", text: "Deutsch" }], { locale: "pt", text: "Português" }], 17:12:17.918 | | ^ 17:12:17.918 | 100 | logo: Potter DB: Docs, 17:12:17.918 | 101 | project: { 17:12:17.918 | 102 | link: "https://github.com/danielschuster-muc/potter-db", 17:12:17.959 | Error: Command "npm run build" exited with 1

Seems to be an issue with the theme.config.tsx.

danielschuster-muc avatar Oct 31 '23 18:10 danielschuster-muc

@danielschuster-muc, can you please review?

cnfranco avatar Oct 31 '23 20:10 cnfranco

Please always add an empty line after the Headers. E.g.:

# Title

and here comes the text after one empty line

Also don't forget to translate the resource pages for books, chapter, characters etc.

Done.

cnfranco avatar Dec 18 '23 02:12 cnfranco

Also don't forget to translate the resource pages for books, chapter, characters etc.

danielschuster-muc avatar Dec 30 '23 19:12 danielschuster-muc