TagKit
TagKit copied to clipboard
danielsaidi
Added OnNewTag, allows to react to Return key in TagTextField, fixed fatal problem with landscape mode
Added possibility to trigger action when tapped on tag. Fixed an issue with geometry reader in landscape mode.
Hi @Vithanco
Thank you for the PR.
To help me understand, why is the geometry reader thing needed? What are the problems in landscape? Please clarify, since I don't want to use GeometryReader unless explicitly needed.
In the tag list, the idea is that you can add everything you need to the view builder, so adding an additional action parameter should not be necessary.
The text field also should not need the action parameter, since you can just add the onSubmit to the tag text view. You do not need to specify that within that view.
you are absolutely right, Daniel! I guess the way how you can use SwiftUI are still not internalised on my side. I removed tap gesture and on submit. Thanks!
I am not a fan of geometry reader neither. But please notice that I didn't introduce it, I only refactored your code. The problem that your code has is that it lead to a program abortion, and the updated version seems to work (and hopefully is better to read).
this fixes issue generated here https://github.com/danielsaidi/TagKit/issues/4
edit: it doesnt
Sorry for completely dropping the ball on this @Vithanco!
If this solves the problem with Swift 6, I will give it a try, then merge it and re-enable Swift 6 👍
Sorry for completely dropping the ball on this @Vithanco!
If this solves the problem with Swift 6, I will give it a try, then merge it and re-enable Swift 6 👍
sorry i used his repo directly which didnt have swift 6 so maybe thats why it worked. Ill check his commit with swift 6 and let you know!
sorry i used his repo directly which didnt have swift 6 so maybe thats why it worked. Ill check his commit with swift 6 and let you know!
Thank you!
sorry i used his repo directly which didnt have swift 6 so maybe thats why it worked. Ill check his commit with swift 6 and let you know!
Thank you!
this pr doesnt fix that error. But your latest 0.4.1 with swift 5.9 builds fine!
Hi @Vithanco
I have updated the library for Swift 6, and simplified many views.
Does this still happen?
@Vithanco I am currently swamped with work, but will take a look at this in Xcode 26 in a few weeks.