Daniel Roe

Results 2592 comments of Daniel Roe

I think we can optimise for a single start rather than frequent reload. --- _Having said that_ (and this isn't a reason not to merge this one) I think PRs...

I understand that _this_ PR is about memory management. My comment (below the horizontal rule) was more general. I am worried that it's possible for large PRs to have a...

Just a quick note on profiling, I'd like to run it on a real nuxt server. We can, for example, trigger HMR or trigger restarts with Nuxt hooks. If you...

This is not yet triaged; that's normally when the bug label is applied.

So, I had a look. The following is a sufficient reproduction in the framework playground: ```ts export default defineNuxtConfig({ typescript: { typeCheck: true } }) export interface I18nConfig { defaultLocale:...

I think this is a cache issue. Try removing your `node_modules` folder and retry. After refreshing node_modules in stackblitz, it also works fine: https://stackblitz.com/edit/github-ajlxyx-31gy3h.

Would you see if you can reproduce this in pure Nitro ([reproduction sandbox](https://stackblitz.com/github/unjs/nitro/tree/main/examples/hello-world)), and if so, raise [there](https://github.com/unjs/nitro/issues/new/choose)? 🙏

thank you for picking this up ❤️

The linked code doesn't grab it from the commit message but directly uses the linked GitHub account `login`. This works around the issue with 'looking up' an account by email...