Swift-ActionCableClient icon indicating copy to clipboard operation
Swift-ActionCableClient copied to clipboard
verified publisher icon danielrhodes

Swift 4.2 support.

Open glm4 opened this issue 6 years ago • 3 comments

Migrate swift version to 4.2 in all targets and dependencies.

glm4 avatar May 06 '19 19:05 glm4

@glm4 This latest upgrade doesn't stable. The onReceive callback works sometime (the same issue to version 0.2.4). However if I revert to 0.2.3, then it works very well.

anphanngocvn avatar May 15 '19 00:05 anphanngocvn

@glm4 This latest upgrade doesn't stable. The onReceive callback works sometime (the same issue to version 0.2.4). However if I revert to 0.2.3, then it works very well.

this happens because if let item = idJSON.first { channelIdentifier = item.value as? String } in JSONSerializer, guess we need another fork..

amakhonin avatar Jul 11 '19 15:07 amakhonin

@glm4 This latest upgrade doesn't stable. The onReceive callback works sometime (the same issue to version 0.2.4). However if I revert to 0.2.3, then it works very well.

I guess that's not in the scope of this PR.

glm4 avatar Jul 24 '19 13:07 glm4