Swift-ActionCableClient icon indicating copy to clipboard operation
Swift-ActionCableClient copied to clipboard

Resolved - Swift Access Races in multi-threading causing memory issues

Open fahidattique55 opened this issue 6 years ago • 5 comments

This has been tested by my team for multiple days and we did not found any multi-threading issue after QA. So I think i'ts stable now and you can merge it in new versions of it.

fahidattique55 avatar Nov 05 '18 03:11 fahidattique55

thank you for fixing this, I had been working on tracking the same problem. your fork seems to do the trick for me.

Imperiopolis avatar Jan 02 '19 20:01 Imperiopolis

@Imperiopolis @danielrhodes

Are you going to merge the pull request?

fahidattique55 avatar Dec 06 '19 09:12 fahidattique55

Since the release of iOS 13, we noticed a lot of new crashes (com.ActionCableClient.Conccurent EXC_BAD_ACCESS KERN_INVALID_ADDRESS) related to Action Cable Client and usually pointing to swift_isUniquelyReferenced_nonNull_native.

We've been using this PR in production for a week and all those crashes are gone, so thank you for your contribution!

Mathbl avatar Dec 09 '19 16:12 Mathbl

@Mathbl

Thanks for the appreciation. It means a lot.

fahidattique55 avatar Dec 09 '19 16:12 fahidattique55

@danielrhodes it would be great to see this merged.

Alternatively - if you're not able to maintain this project any more for whatever reason, it would be great if you could let people know so that someone else can step in.

thanks :)

ConfusedVorlon avatar Dec 19 '19 13:12 ConfusedVorlon