Daniel

That's a cool idea...is there a step-by-step guide on how to do this? Especially for a ffi/so lib like this one?

That means there's a bug in our state tracking. If you can post your video somewhere we can have a look. This library is in a rather early state, so...

Hmmm should probably copy the license from https://github.com/google/brotli/blob/master/LICENSE

I don't think a macro is the right approach here. You could have a function that takes in a mut ref, but I'm not sure it's more readable than the...

I only tested with a very old version of brotli--it seems like the new brotli does export BrotliSetDictionaryData dictionary functions in libbrotlicommon that is not present in this version If...

BrotliDecompressor does have a dict flag... does this fulfill your needs? https://github.com/dropbox/rust-brotli/blob/master/src/bin/brotli.rs#L537 Can you test to see if this feature succeeds in decompressing files compressed with a custom dictionary?

You should pass an allocator per thread so that it can allocate from each thread. If your allocator is thread safe then you can share the same one.

The idea here is to allow floatX to either be f32 and f64...that way I think we can guarantee bit-wise exact comparisons to google/brotli However I believe some of the...

I don't understand why this change alters USE_DICTIONARY but not the other 3 in the trait. I think we should either adjust all of them or pause until we can.......

I think its' fine to merge the repos if that makes it easier. We need to keep the crates separate... otherwise you could end up with massive code duplication consider...