Daniel Norberg

Results 42 comments of Daniel Norberg

NPE on from() when nullable collection unset (since 0.22)

This indeed seems like a bug. Would you like to contribute a fix?

NPE on from() when nullable collection unset (since 0.22)

Sounds good. Don’t remember now exactly why spotbugs complained though.

Don't emit `@SafeVarargs` for reifiable types

~~@lepistone That indeed seems like a simpler approach. 👍~~

Don't emit `@SafeVarargs` for reifiable types

Would using `@SuppressWarnings("varargs")` help in this case though? Adding it to a method with a reifiable vararg parameter does not seem to make IntelliJ happier about the method. Javac with...

Don't emit `@SafeVarargs` for reifiable types

@lepistone Indeed. I had simply failed to enable `showWarnings`. https://github.com/danielnorberg/auto-matter/pull/72

Don't emit `@SafeVarargs` for reifiable types

Although the `@SuppressWarnings("varargs")` has been released in `0.15.3`, I guess it could still be neat to avoid both `@SafeVarargs` and `@SuppressWarnings` in code generated for reifiable types.

Don't emit `@SafeVarargs` for reifiable types

@bndbsh I attempted to handle nested types here, please take a look: https://github.com/mninja/auto-matter/pull/1

field default values

TODO: - Allow `Optional` fields? - Allow collection/map fields? - Add `@AutoMatter.Default` annotation instead of using `@AutoMatter.Field`?

field default values

**Note**: does not work well with gson as it bypasses the value constructor.

Refactor processor to make extension easier

This is a much-needed refactoring. Kudos! Looks great overall, just a few small comments. * Eliminate circular imports and dependencies. * Everything should be package-private or private. * Leave everything...