Daniel Nixon

Results 116 comments of Daniel Nixon

I'm conflicted about this one. It would be good to add this rule to nudge lodash users towards lodash-fp, but then again people shouldn't even be using lodash (or lodash-fp)...

https://github.com/danielnixon/link-fixer/blob/master/background-script.js#L100-L120

Duplicate of https://github.com/danielnixon/link-fixer/issues/13 ?

This add-on will respect the value of Firefox's [newTabPosition](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/browserSettings/newTabPosition) if it's available. If it's not available, this add-on will fall back on `relatedAfterCurrent`, which happens to be the default value...

Oh my apologies, I think I misinterpreted and got your expected and actual switched around in my mind. In which case maybe there's an issue in my [relatedAfterCurrent](https://github.com/danielnixon/link-fixer/blob/master/background-script.js#L74-L88) impl in...

Thanks @buethastum. I don't have time to work on this right now but PRs always welcome.