danielmunioz

Close #6591

Closing this as inactive, as it has been more than 2 weeks without any activity

Hey @AmgadHasan! Thanks for contributing! I left a quick review on line 107 of `ivy_tests/test_ivy/test_frontends/test_torch/test_linalg.py` could you please fix that and then run the tests? It looks like the testing...

Hey @AmgadHasan! You can find the review by going to the 'Files Changed' tab here on Github, I'll ping you there as well

That's so weird 🤔, I can see it on my end, guess it's just a github bug then Anyways, for line 107 of `ivy_tests/test_ivy/test_frontends/test_torch/test_linalg.py` the name of the input argument...

Hey @AmgadHasan, sorry but the tests are not passing yet, could you please run them locally and make sure they're passing? The github are random across the repo and examples...

Hey @shaimah! Thanks for contributing! Just a minor detail, the default value of `p` should be 2 and x should be called `input` in the function arguments I believe, the...

Hey @shaimah! I just checked your PR again, thanks for the changes! It seems to be working well and the tests are passing locally, the only thing left is to...

Hey @melch-inno!, Thanks for contributing! It looks like you have some misnamed and some missing arguments in your function, could you please take a look at those?, a frontend implementation...

Hey @melch-inno, so it seems that you are using `eps` instead of `epsilon` in the frontend testing helper and so the function cannot properly recognize the argument name, argument names...