date-time-picker icon indicating copy to clipboard operation
date-time-picker copied to clipboard

Invalid input is silently discarded

Open komu opened this issue 4 years ago • 3 comments

I have an existing time in the picker, then open the picker and input invalid hour:

Screenshot 2021-01-29 at 12 45 54

Nothing is indicated as being invalid and Set button is enabled. When I click Set, the valid parts of my input (minutes) are set to new values, but the invalid hours are not:

Screenshot 2021-01-29 at 12 46 16

Similarly if I would have entered 13:65 as input, the valid part (hours) would have been copied, but the minutes not. Same happens if either hours or minutes are left completely blank.

I would expect that Set is disabled when the input in the dialog is not valid.

komu avatar Jan 29 '21 10:01 komu

closing.. stale

danielmoncada avatar May 10 '23 04:05 danielmoncada

Then again, the problem still seems to be there.

komu avatar May 10 '23 07:05 komu

@komu okay, I'll re-open. feel free to make a PR to fix it 👍

danielmoncada avatar May 11 '23 17:05 danielmoncada