Daniel Müller-Komorowska

Review going well. Mainly waiting for code and data to confirm the GPU performance. See https://github.com/padster/pyNeuroTrace/issues/7

Hello @adamltyson I just ran the GPU code so I can confirm the performance claim. That was my last major item. I opened one last issue regarding the source of...

@adamltyson Yes I recommend acceptance. I just want to note that I made the authors add a statement on animal ethics, since the in-vivo data in the paper is not...

Thank you for the detailed review of the PR and sorry for the messy commented out code. I've gone through all the comments and made the suggested changes. Many of...

I worked through https://github.com/sbi-dev/sbi/blob/main/docs/advanced_tutorials/17_plotting_functionality.ipynb and some of the functionality that works in the main branch is broken in my PR. I also might have misunderstood the point of passing different...

Sorry for the delay on this. During the hackathon I underestimated the complexity of the pairplot function. Salvaging this pull request by fixing the features I broke, would be too...

I want to apologize for not getting to this @gmoss13. After the hackathon, I did not have the bandwidth. I see there is now a much better PR for pairplot...

I could work on this during the hackathon.

I've looked in detail at the `pairplot` function. I went through all the notebooks and tried to break the interface. The interface is actually pretty good and flexible. The only...

Yes I can see how having multiple kwarg style argument introduces problems. Hard to say how to improve on this while maintaining backwards compatibility. One direction I am investigating: I...