SecLists icon indicating copy to clipboard operation
SecLists copied to clipboard

Improved checker scripts

Open molangning opened this issue 1 year ago • 2 comments

The current new line checker is too "harsh" as it exists immediately when ran. Normally that is a non issue but having to repair and commit only for it fail is quite frustrating

The workflow now uses github actions summary and adds more details to the checks, letting the person who opened the pull request know what checks are failing and how to change them

molangning avatar Nov 26 '23 14:11 molangning

Here is the workflow running https://github.com/molangning/SecLists/actions/runs/7048714772

Screenshot_2023-11-30_23-37-17

molangning avatar Nov 30 '23 15:11 molangning

passed field looks abit wonky

molangning avatar Nov 30 '23 15:11 molangning

Hey @molangning There is now a merge conflict - would you be able to look into it?

g0tmi1k avatar Feb 13 '24 15:02 g0tmi1k

@g0tmi1k #963 has a commit that changed new line checker to be more lenient, but the recent commits that I did has already made it more lenient. Unfortunately, I can’t do anything on my side as resolving the conflict has to be done on your side. You should be able to merge my changes without any repercussions.

There is a great guide by github on resolving merge conflicts through github web. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github

molangning avatar Feb 14 '24 04:02 molangning

Hi @molangning , I can't push to molangning/SecLists, as a result it needs to be addressed by yourself.

Otherwise, I'll close the MR and you can re-open it later if you wish.

g0tmi1k avatar Feb 16 '24 13:02 g0tmi1k

Rebase time :tada:

molangning avatar Feb 16 '24 15:02 molangning