Fabric icon indicating copy to clipboard operation
Fabric copied to clipboard

[Bug]: 97% of the source package is taken by Fabric logo images

Open vaygr opened this issue 10 months ago • 2 comments

What happened?

I didn't check when this changed, but apparently has been going on since #471.

The source package of Fabric is 174.13M, and the majority of extracted space is taken by 4 identical files (sha1:834bee80736ed87aa7ff6217e39cd4bbac04c2e3 as of 1.4.156):

  • images/fabric-logo-gif.gif: 44.5M
  • web/static/fabric-logo.gif: 44.5M
  • web/static/fabric-logo.png: 44.5M
  • web/static/favicon.png: 44.5M

Removing these files and repackaging it reduces the package size down to 5.49M.

Was this an oversight? Some weird steganography trick? What value does it provide?

Version check

  • [x] Yes I was.

Relevant log output


Relevant screenshots (optional)

No response

vaygr avatar Mar 12 '25 18:03 vaygr

Wrong on many levels:

  • Two png files with wrong extension, that are gif.
  • Four identical files (tested with fclones), should be only one.
  • Too big file sizes, should be bellow 1M (not everyone has fast connection).
  • Strange big resolution (1292x1293), use 1080p or lower.
  • Too many frames of animation (>30fps), reduce fps and duration.
$ exiftool fabric-logo.gif | grep -E "Si|Du|Fra"
File Size                       : 44 MB
Frame Count                     : 240
Duration                        : 8.01 s
Image Size                      : 1292x1293

Using gifski to reduce frames and resolution:

$ gifski --fps 12 --height 540 -o optimized.gif fabric-logo.gif

Comparing file size:

$ du -h *gif
43M     fabric-logo.gif
5.3M    optimized.gif

Still is big, but a lot smaller (8x). Can be smaller reducing ammount of colors.


PD: Original image seems vector created, shouldn't be smaller and best quality use SVG animation that any browser can play?

Disonantemus avatar Mar 22 '25 18:03 Disonantemus