Daniel Mewes
Daniel Mewes
Good question. I'm actually not sure what the reason behind the fork was. @deontologician @coffeemug do you know more about this?
Thanks for reporting this @chovy . As the error message says we renamed `returnVals` to `returnChanges`, and apparently forgot to update this example. Pinging @deontologician
Never mind, I opened a pull request https://github.com/rethinkdb/rethinkdb-example-nodejs/pull/13
Thanks for the report @rohitgup14. That's weird. @deontologician any ideas?
Thanks for letting us know @samkelleher. Once you get things running with the latest driver, a pull request would be amazing so we can merge it into the example code...
@deontologician Fair enough. Did you check that the code actually works with the new driver (in case we changed the syntax or name of some command)?
Good catch @codinfox . It doesn't look like it's intentional to me (though I could be wrong). @deontologician is currently out of office, but he will look into it when...
Pinging @deontologician (though I think this isn't super critical).
Thanks a lot for your pull requests @aderyabin! Unless you have already done so, can you please sign our contributor agreement http://rethinkdb.com/community/cla/ ? @mlucy Can you take a look?
@mlucy It seems @al3xandru did, so that might be difficult. @chipotle and @mglukhovsky have both done smaller maintenance since then https://github.com/rethinkdb/rethinkdb-example-sinatra-pastie/commits/master .